-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/django setup configuration tokens #135
Merged
danielmursa-dev
merged 63 commits into
master
from
issue/django-setup-configuration-tokens
Dec 13, 2024
Merged
Issue/django setup configuration tokens #135
danielmursa-dev
merged 63 commits into
master
from
issue/django-setup-configuration-tokens
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmursa-dev
force-pushed
the
issue/django-setup-configuration-tokens
branch
from
December 10, 2024 11:51
7cae0ea
to
8858b43
Compare
swrichards
reviewed
Dec 12, 2024
src/objecttypes/setup_configuration/tests/files/token_auth/valid_setup_complete.yaml
Outdated
Show resolved
Hide resolved
stevenbal
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, though it would be preferred to have the namespace changed to tokenauth
as Sidney suggested
…enauth" This reverts commit a2c9c59.
stevenbal
approved these changes
Dec 13, 2024
swrichards
requested changes
Dec 13, 2024
swrichards
approved these changes
Dec 13, 2024
swrichards
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes maykinmedia/objects-api#481
Fixes maykinmedia/objects-api#487
Changes